Bug 24221 – [GTK] Do not emit load-finished when being disposed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

webkit_web_view_stop_load() is called from dispose() on WebKitWebView. This eventually calls postProgressFinishedNotification in FrameLoaderClientGtk, which emits load-finished. Add a 'disposing' flag to WebView that we can check here, so we avoid emitting signals on objects on their way to be destroyed. This fixes a bunch of critical warnings when closing a loading WebView.

[Xan Lopez]

Created attachment 28067 [details]
disposing.patch

[Alexey Proskuryakov]

Comment on attachment 28067 [details]
disposing.patch

r=me

> +    /*
> +     * We can get a stopLoad() from dispose when the object is being
> +     * destroyed, don't emit the signal in that case.
> +     */

We prefer C++-style comments in C++ files.

Is this check needed before other g_signal_emit_by_name() calls?

[Xan Lopez]

(In reply to comment #2)
> (From update of attachment 28067 [details] [review])
> r=me
> 
> > +    /*
> > +     * We can get a stopLoad() from dispose when the object is being
> > +     * destroyed, don't emit the signal in that case.
> > +     */
> 
> We prefer C++-style comments in C++ files.

OK, was just being consistent with other multi-line comments in the file :)

> 
> Is this check needed before other g_signal_emit_by_name() calls?
> 

Does not seem so, this is the only signal emitted during dispose AFAICT. We generally try to protect only the code paths needed on dispose, otherwise you'd need to protect every single function and signal just in case.

[Jan Alonzo]

Landed in r41284. Thanks!