Bug 242209 - Remove GraphicsLayer::supportsRoundedClip and RenderLayerBacking::m_childClippingMaskLayer
Summary: Remove GraphicsLayer::supportsRoundedClip and RenderLayerBacking::m_childClip...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-30 14:50 PDT by Fujii Hironori
Modified: 2022-07-19 20:39 PDT (History)
12 users (show)

See Also:

Attachments
Patch (12.15 KB, patch)
2022-06-30 14:55 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-06-30 14:50:43 PDT 
After 252014@main (bug#242097), GraphicsLayer::supportsRoundedClip returns true for all ports.
We can remove it.
Comment 1 Fujii Hironori 2022-06-30 14:55:57 PDT 
Created attachment 460589 [details]
Patch
Comment 2 EWS 2022-07-01 14:06:19 PDT 
Committed 252070@main (c1a2e7ae525f): <https://commits.webkit.org/252070@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460589 [details].
Comment 3 Radar WebKit Bug Importer 2022-07-01 14:07:13 PDT 
<rdar://problem/96313350>
Comment 4 Robert Jenner 2022-07-15 23:42:59 PDT 
I am re-opening this bug because I had to do a partial revert of 25070@main. The changes committed to updateGeometry at that change caused testing on iOS 16 Debug beta to crash and never complete.

I added the crashlog text to this bug: 

https://bugs.webkit.org/show_bug.cgi?id=242832


Additionally I added the revert needed to that bug, and it is currently going through testing.
Comment 5 Fujii Hironori 2022-07-16 05:52:44 PDT 
I can't believe. My change just removed unused code. I should have no effect.
Comment 6 Darin Adler 2022-07-16 14:27:10 PDT 
I agree. This doesn’t make logical sense.
Comment 7 Fujii Hironori 2022-07-19 20:39:06 PDT 
bug#242832 was resolved. Closed this bug again.