RESOLVED FIXED 242112
[LFC][FFC] Add support for non-stretching flex items with flex-basis 
https://bugs.webkit.org/show_bug.cgi?id=242112
Summary [LFC][FFC] Add support for non-stretching flex items with flex-basis
alan
Reported 2022-06-29 09:34:17 PDT
where flex-basis != logical width
Attachments
Patch (5.43 KB, patch)
2022-06-29 09:43 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2022-07-01 20:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-06-29 09:43:33 PDT
Created attachment 460543 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-06-29 10:58:28 PDT
Comment on attachment 460543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460543&action=review > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:232 > + auto flexedSize = reolvedFlexItem.flexBasis + reolvedFlexItem.flexGrow * flexGrowBase; > + if (flexedSize && reolvedFlexItem.minimumSize >= flexedSize) { > + reolvedFlexItem.isFrozen = true; > didFreeze = true; > - totalGrowth -= stretchingFlex.flexGrow; > - totalFlexibleSpace -= stretchingFlex.flexBasis; > - availableSpace -= stretchingFlex.minimumSize; > + totalGrowth -= reolvedFlexItem.flexGrow; > + totalFlexibleSpace -= reolvedFlexItem.flexBasis; > + availableSpace -= reolvedFlexItem.minimumSize; > } typo: reolved
alan
Comment 3 2022-07-01 20:21:26 PDT
Created attachment 460629 [details] Patch
EWS
Comment 4 2022-07-01 21:37:27 PDT
Committed 252087@main (02229f46cd9b): <https://commits.webkit.org/252087@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460629 [details].
Radar WebKit Bug Importer
Comment 5 2022-07-01 21:38:14 PDT
<rdar://problem/96330047>
Note You need to log in before you can comment on or make changes to this bug.