Bug 24210 - Improvements to autotools configuration of the build script
Summary: Improvements to autotools configuration of the build script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-02-26 15:27 PST by Gustavo Noronha (kov)
Modified: 2009-03-01 10:23 PST (History)
0 users

See Also:


Attachments
adds option to enable gnome keyring (3.60 KB, patch)
2009-02-26 15:28 PST, Gustavo Noronha (kov)
zecke: review+
Details | Formatted Diff | Diff
adds a new environment variable to enable passing arguments to make (1.47 KB, patch)
2009-02-26 15:30 PST, Gustavo Noronha (kov)
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-02-26 15:27:48 PST
The script doesn't allow us to enable GNOME Keyring, and passing arguments such as -j to the call to make. I suggest we add both =).
Comment 1 Gustavo Noronha (kov) 2009-02-26 15:28:35 PST
Created attachment 28044 [details]
adds option to enable gnome keyring
Comment 2 Gustavo Noronha (kov) 2009-02-26 15:30:08 PST
Created attachment 28045 [details]
adds a new environment variable to enable passing arguments to make
Comment 3 Holger Freyther 2009-03-01 07:14:51 PST
Comment on attachment 28044 [details]
adds option to enable gnome keyring


> @@ -70,7 +71,7 @@ Usage: $programName [options] [options to pass to build system]
>    --cairo-win32                 Build using Cairo (rather than CoreGraphics) on Windows
>    --chromium                    Build the Chromium port on Mac/Win/Linux
>    --clean                       Cleanup the build directory
> -  --gtk                         Build the GTK port
> +  --gtk                         Build the GTK+ port

make this a separate commit (rs=me on this).
Comment 4 Holger Freyther 2009-03-01 07:16:38 PST
Comment on attachment 28045 [details]
adds a new environment variable to enable passing arguments to make

hmmm... okay... unlikely to break someone else ports and it is unlikely that we see breakage from that (shell and quotes always make me nervous).
Comment 5 Gustavo Noronha (kov) 2009-03-01 10:23:45 PST
Landed as r41327 and r41328.