Bug 242089 - [Make] Avoid passing default xcodebuild options to installsrc
Summary: [Make] Avoid passing default xcodebuild options to installsrc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-28 16:05 PDT by Elliott Williams
Modified: 2022-07-01 09:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-06-28 16:05:40 PDT 
Our "standard" xcodebuild options, as computed by `XcodeOptionString()` in webkitdirs, are not suitable for `xcodebuild installsrc`. In particular, they can lead to PIFCache directories being created in WebKitBuild that are created as a side effect of installsrc.
Comment 1 Elliott Williams 2022-06-28 16:07:02 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1877
Comment 2 Elliott Williams 2022-06-28 16:08:02 PDT 
rdar://95680722
Comment 3 EWS 2022-07-01 09:54:56 PDT 
Committed 252050@main (c68a647dbadb): <https://commits.webkit.org/252050@main>

Reviewed commits have been landed. Closing PR #1877 and removing active labels.