Bug 242008 - [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content
Summary: [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-25 14:15 PDT by zalan
Modified: 2022-06-29 06:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2022-06-25 14:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-06-25 14:15:53 PDT 
ssia
Comment 1 zalan 2022-06-25 14:18:14 PDT 
Created attachment 460493 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-06-25 14:21:49 PDT 
Comment on attachment 460493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460493&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:705
>          if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned())

You can remove `flexItem.isFloating()` as mentioned last time
Comment 3 zalan 2022-06-28 20:33:15 PDT 
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 460493 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460493&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:705
> >          if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned())
> 
> You can remove `flexItem.isFloating()` as mentioned last time
Thanks, will do.
Comment 4 EWS 2022-06-28 21:05:11 PDT 
Committed 251942@main (559f12392f3f): <https://commits.webkit.org/251942@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460493 [details].
Comment 5 Radar WebKit Bug Importer 2022-06-28 21:06:15 PDT 
<rdar://problem/96111679>
Comment 6 Tim Nguyen (:ntim) 2022-06-28 23:22:04 PDT 
Comment on attachment 460493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460493&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:687
> +        // FIXME: Find out why we constrcut RenderFlexibleBoxes for non-flex content.

Isn't this because of all the subclasses of RenderFlexibleBox? (RenderSliderContainer, RenderButton, RenderFullscreen, RenderMenulist, RenderSlider and RenderTextControlInnerContainer)
Comment 7 zalan 2022-06-29 06:25:57 PDT 
(In reply to Tim Nguyen (:ntim) from comment #6)
> Comment on attachment 460493 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460493&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:687
> > +        // FIXME: Find out why we constrcut RenderFlexibleBoxes for non-flex content.
> 
> Isn't this because of all the subclasses of RenderFlexibleBox?
> (RenderSliderContainer, RenderButton, RenderFullscreen, RenderMenulist,
> RenderSlider and RenderTextControlInnerContainer)
Maybe. I didn't care enough to look. It's super low priority at this point.
Comment 8 zalan 2022-06-29 06:27:21 PDT 
(In reply to zalan from comment #7)
> (In reply to Tim Nguyen (:ntim) from comment #6)
> > Comment on attachment 460493 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=460493&action=review
> > 
> > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:687
> > > +        // FIXME: Find out why we constrcut RenderFlexibleBoxes for non-flex content.
> > 
> > Isn't this because of all the subclasses of RenderFlexibleBox?
> > (RenderSliderContainer, RenderButton, RenderFullscreen, RenderMenulist,
> > RenderSlider and RenderTextControlInnerContainer)
Thanks.