RESOLVED FIXED 242008
[LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content 
https://bugs.webkit.org/show_bug.cgi?id=242008
Summary [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content
alan baradlay
Reported 2022-06-25 14:15:53 PDT
ssia
Attachments
Patch (3.03 KB, patch)
2022-06-25 14:18 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan baradlay
Comment 1 2022-06-25 14:18:14 PDT
Created attachment 460493 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-06-25 14:21:49 PDT
Comment on attachment 460493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460493&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:705 > if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned()) You can remove `flexItem.isFloating()` as mentioned last time
alan baradlay
Comment 3 2022-06-28 20:33:15 PDT
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 460493 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=460493&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:705 > > if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned()) > > You can remove `flexItem.isFloating()` as mentioned last time Thanks, will do.
EWS
Comment 4 2022-06-28 21:05:11 PDT
Committed 251942@main (559f12392f3f): <https://commits.webkit.org/251942@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460493 [details].
Radar WebKit Bug Importer
Comment 5 2022-06-28 21:06:15 PDT
<rdar://problem/96111679>
Tim Nguyen (:ntim)
Comment 6 2022-06-28 23:22:04 PDT
Comment on attachment 460493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460493&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:687 > + // FIXME: Find out why we constrcut RenderFlexibleBoxes for non-flex content. Isn't this because of all the subclasses of RenderFlexibleBox? (RenderSliderContainer, RenderButton, RenderFullscreen, RenderMenulist, RenderSlider and RenderTextControlInnerContainer)
alan baradlay
Comment 7 2022-06-29 06:25:57 PDT
(In reply to Tim Nguyen (:ntim) from comment #6) > Comment on attachment 460493 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=460493&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:687 > > + // FIXME: Find out why we constrcut RenderFlexibleBoxes for non-flex content. > > Isn't this because of all the subclasses of RenderFlexibleBox? > (RenderSliderContainer, RenderButton, RenderFullscreen, RenderMenulist, > RenderSlider and RenderTextControlInnerContainer) Maybe. I didn't care enough to look. It's super low priority at this point.
alan baradlay
Comment 8 2022-06-29 06:27:21 PDT
(In reply to zalan from comment #7) > (In reply to Tim Nguyen (:ntim) from comment #6) > > Comment on attachment 460493 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=460493&action=review > > > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:687 > > > + // FIXME: Find out why we constrcut RenderFlexibleBoxes for non-flex content. > > > > Isn't this because of all the subclasses of RenderFlexibleBox? > > (RenderSliderContainer, RenderButton, RenderFullscreen, RenderMenulist, > > RenderSlider and RenderTextControlInnerContainer) Thanks.
Note You need to log in before you can comment on or make changes to this bug.