Bug 242001 - Remove GraphicsLayer::setMasksToBoundsRect
Summary: Remove GraphicsLayer::setMasksToBoundsRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-25 06:00 PDT by Fujii Hironori
Modified: 2022-06-28 13:09 PDT (History)
10 users (show)

See Also:

Attachments
WIP patch (3.68 KB, patch)
2022-06-25 06:05 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (7.50 KB, patch)
2022-06-27 14:18 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (8.95 KB, patch)
2022-06-27 14:24 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-06-25 06:00:25 PDT 
Remove GraphicsLayer::setMasksToBoundsRect

I don't know why GraphicsLayer::setMasksToBoundsRect is needed.
GraphicsLayer has the following similar desendants clipping methods.

 GraphicsLayer::setContentsClippingRect(const FloatRoundedRect& roundedRect)
 GraphicsLayer::setContentsRectClipsDescendants(bool b)
Comment 1 Fujii Hironori 2022-06-25 06:05:41 PDT 
Created attachment 460491 [details]
WIP patch
Comment 2 Simon Fraser (smfr) 2022-06-27 09:02:47 PDT 
setMasksToBoundsRect sets the rect used to clip descendant GraphicsLayers.

setContentsClippingRect sets the rect used to clip only this layer's content layer.
Comment 3 Simon Fraser (smfr) 2022-06-27 09:06:09 PDT 
Comment on attachment 460491 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460491&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:-408
> -    m_masksToBoundsRect = roundedRect;

You don't remove the m_masksToBoundsRect member variable. If you do, you'll find that it's referenced in GraphicsLayerCA::updateMasksToBoundsRect().
Comment 4 Fujii Hironori 2022-06-27 12:56:25 PDT 
That's the reason why I used setContentsRectClipsDescendants together. I'm going to try to remove all related code. Thank you for the comment.
Comment 5 Fujii Hironori 2022-06-27 14:18:06 PDT 
Created attachment 460506 [details]
Patch
Comment 6 Fujii Hironori 2022-06-27 14:24:53 PDT 
Created attachment 460507 [details]
Patch
Comment 7 EWS 2022-06-28 13:08:19 PDT 
Committed 251923@main (2e43c7cbb61a): <https://commits.webkit.org/251923@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460507 [details].
Comment 8 Radar WebKit Bug Importer 2022-06-28 13:09:16 PDT 
<rdar://problem/96085182>