Bug 241960 - [WebIDL] Cache extended attributes of WebIDL file
Summary: [WebIDL] Cache extended attributes of WebIDL file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-24 02:30 PDT by Diego Pino
Modified: 2022-10-17 04:58 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-06-24 02:30:24 PDT 
Currently the function `GetInterfaceExtendedAttributesFromName` computes a list of extended attributes by opening an IDL file and parsing its contents. The function could cache its results so it doesn't need to compute the list again in case the same IDL file is parsed. There are other functions in CodeGenerator.pm, like `GetDictionaryByType` or `GetEnumByType`, that also cache their results.
Comment 1 Diego Pino 2022-06-24 02:32:43 PDT 
Pull request: https://github.com/webkit/webkit/pull/1769
Comment 2 Radar WebKit Bug Importer 2022-07-01 02:31:13 PDT 
<rdar://problem/96280013>
Comment 3 EWS 2022-10-17 04:58:27 PDT 
Committed 255617@main (c7da26fb5135): <https://commits.webkit.org/255617@main>

Reviewed commits have been landed. Closing PR #1769 and removing active labels.