Bug 24186 – Regression RTL: text truncation with text-overflow:ellipsis does not work correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Xiaomei Ji]

This is a regression, happens in nightly build r41128, but not in Safari 3.2.1.

Bidi text "MSN Arabia رياضه، أخبار، مرآة، أفلام، موسيقى، جمال، سيارات، اقتصاد و المزيد على" was truncated wrong when the following style was specified:

  display:block;
  overflow: hidden;
  text-overflow: ellipsis;
  white-space: nowrap;
  width: 207px;

The truncation seems wrongly truncated the leading English characters.

test case is attached.

[Xiaomei Ji]

Created attachment 28008 [details]
text overflow truncation

[Xiaomei Ji]

Also in Chrome bug
http://code.google.com/p/chromium/issues/detail?id=7697

[Jeremy Moskovich]

The reason that the English text run is truncated is because of the way the loop in InlineFlowBox::placeEllipsisBox() works.

It iterates over all of it's children from left to right till it finds the one containing the ellipsis, all boxes after that one are marked as hidden.  This happens when foundBox is set to true.

The fix is to change the order of iteration for the RTL case so we can correctly truncate the children to the left of the ellipsis.

[Jeremy Moskovich]

Created attachment 29400 [details]
Patch 1

Vary the order of iteration based on direction.

[Jeremy Moskovich]

Created attachment 29401 [details]
Patch 2

Add bug URL to changelog

[Jeremy Moskovich]

Comment on attachment 29401 [details]
Patch 2

Clearing review flag since I'm rolling this fix into the patch for bug 25135.

[Dimitri Glazkov (Google)]

Fixed in http://trac.webkit.org/changeset/43664.