Bug 241824 - git-webkit broke webkitbot
Summary: git-webkit broke webkitbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on: 242277
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-06-21 15:50 PDT by Yusuke Suzuki
Modified: 2022-07-01 16:30 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-06-21 15:50:57 PDT 
It looks like webkitbot is broken after git-webkit migration.
Comment 1 Radar WebKit Bug Importer 2022-06-21 15:52:04 PDT 
<rdar://problem/95642497>
Comment 2 Yusuke Suzuki 2022-06-21 15:55:29 PDT 
Probably webkit-patch change broke it. Can you revert the change to fix webkitbot?
Comment 3 Jonathan Bedard 2022-06-21 17:16:15 PDT 
Given that the problem is related to deprecation of changelogs, we definitely cannot revert the changes.

It's also not clear why webkitbot is having trouble, its related to local commits in the checkout, but `webkit-patch revert --force-clean` handles this case locally
Comment 4 Jonathan Bedard 2022-07-01 13:51:26 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2011
Comment 5 EWS 2022-07-01 15:44:44 PDT 
Committed 252078@main (8f37a9ae8521): <https://commits.webkit.org/252078@main>

Reviewed commits have been landed. Closing PR #2011 and removing active labels.
Comment 6 WebKit Commit Bot 2022-07-01 16:29:26 PDT 
Re-opened since this is blocked by bug 242277
Comment 7 Jonathan Bedard 2022-07-01 16:30:56 PDT 
(In reply to WebKit Commit Bot from comment #6)
> Re-opened since this is blocked by bug 242277

Just testing webkitbot.