WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24182
Add custom V8 bindings for TreeWalker, NoderIterator, NodeFilter
https://bugs.webkit.org/show_bug.cgi?id=24182
Summary
Add custom V8 bindings for TreeWalker, NoderIterator, NodeFilter
Dimitri Glazkov (Google)
Reported
2009-02-25 21:10:08 PST
Little by little...
Attachments
Add NodeFilter, NodeIterator, and Luke TreeWalker custom V8 bindings, v1.
(10.80 KB, patch)
2009-02-25 21:19 PST
,
Dimitri Glazkov (Google)
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-02-25 21:19:25 PST
Created
attachment 28004
[details]
Add NodeFilter, NodeIterator, and Luke TreeWalker custom V8 bindings, v1. WebCore/ChangeLog | 16 +++ WebCore/bindings/v8/custom/V8NodeFilterCustom.cpp | 48 ++++++++ .../bindings/v8/custom/V8NodeIteratorCustom.cpp | 81 +++++++++++++ WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp | 127 ++++++++++++++++++++ 4 files changed, 272 insertions(+), 0 deletions(-)
Dimitri Glazkov (Google)
Comment 2
2009-02-25 21:20:34 PST
Dear reviewer, if you're eseidel, then this is a deja-revu.
Eric Seidel (no email)
Comment 3
2009-02-26 11:33:01 PST
Comment on
attachment 28004
[details]
Add NodeFilter, NodeIterator, and Luke TreeWalker custom V8 bindings, v1. still looks fine.
Dimitri Glazkov (Google)
Comment 4
2009-02-26 12:48:31 PST
Landed as
http://trac.webkit.org/changeset/41263
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug