Bug 241790 - Fix broken --useOSLog option.
Summary: Fix broken --useOSLog option.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-20 15:07 PDT by Mark Lam
Modified: 2022-06-20 17:04 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-06-20 15:07:24 PDT 
Internally, --useOSLog=0 is represented as OSLogType::None.  Options::dumpAllOptionsInALine() dumps this value as "none".  When "none" is later passed back top Options::setOption(), it is rejected because useOSLog's parse function wasn't expecting "none" as an input string.  The fix is to simply add "none" to the list of allowed input strings.
Comment 1 Mark Lam 2022-06-20 15:13:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1641
Comment 2 EWS 2022-06-20 17:03:04 PDT 
Committed r295677 (251682@main): <https://commits.webkit.org/251682@main>

Reviewed commits have been landed. Closing PR #1641 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-06-20 17:04:14 PDT 
<rdar://problem/95558387>