Bug 241763 - git-webkit pr sometimes produces unexpected results when merging titles of multiple commits
Summary: git-webkit pr sometimes produces unexpected results when merging titles of mu...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-06-19 14:44 PDT by Nikolas Zimmermann
Modified: 2022-06-26 14:45 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-06-19 14:44:43 PDT 
I named a bug report "[LBSE] Add 'viewBox' support" (webkit.org/b/241762) and used git-webkit pr to create a PR, which was only named "[LBSE] Add '" (https://github.com/WebKit/WebKit/pull/1622).

There's a bug related to hyphens, I'll move on and fix the PR name but this might be relevant for others, so I'll open a ticket.
Comment 1 Alexey Proskuryakov 2022-06-20 12:04:23 PDT 
I think that you meant apostrophe, not hyphen - is that right?
Comment 2 Jonathan Bedard 2022-06-21 08:21:08 PDT 
This isn't about hyphens or apostrophes, it's about multiple commits in a PR. git-webkit is trying to craft a title that applies to all the commits in the PR (unsuccessfully, in this case). Basically, all those commits share "[LBSE] Add", so that's what we're titling the PR.

We can definitely improve how we name multi-commit PRs, although it's not obvious exactly what the title of a multi-commit PR should be, especially when commits have as diverse headers as the commits in this PR.
Comment 3 Radar WebKit Bug Importer 2022-06-26 14:45:12 PDT 
<rdar://problem/95941403>