NEW 241763
git-webkit pr sometimes produces unexpected results when merging titles of multiple commits 
https://bugs.webkit.org/show_bug.cgi?id=241763
Summary git-webkit pr sometimes produces unexpected results when merging titles of mu...
Nikolas Zimmermann
Reported 2022-06-19 14:44:43 PDT
I named a bug report "[LBSE] Add 'viewBox' support" (webkit.org/b/241762) and used git-webkit pr to create a PR, which was only named "[LBSE] Add '" (https://github.com/WebKit/WebKit/pull/1622). There's a bug related to hyphens, I'll move on and fix the PR name but this might be relevant for others, so I'll open a ticket.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-06-20 12:04:23 PDT
I think that you meant apostrophe, not hyphen - is that right?
Jonathan Bedard
Comment 2 2022-06-21 08:21:08 PDT
This isn't about hyphens or apostrophes, it's about multiple commits in a PR. git-webkit is trying to craft a title that applies to all the commits in the PR (unsuccessfully, in this case). Basically, all those commits share "[LBSE] Add", so that's what we're titling the PR. We can definitely improve how we name multi-commit PRs, although it's not obvious exactly what the title of a multi-commit PR should be, especially when commits have as diverse headers as the commits in this PR.
Radar WebKit Bug Importer
Comment 3 2022-06-26 14:45:12 PDT
<rdar://problem/95941403>
Note You need to log in before you can comment on or make changes to this bug.