Bug 241752 - DecomposedGlyphs should notify observers in destructor
Summary: DecomposedGlyphs should notify observers in destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-18 16:26 PDT by Cameron McCormack (:heycam)
Modified: 2022-06-21 17:41 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-06-18 16:26:59 PDT
Forgot to do anything with m_observers in the DecomposedGlyphs destructor.  Currently old DecomposedGlyphs objects will hang around in the GPU process until the document goes away, instead of (as is intended) when the display list they are in is removed from the GlyphDisplayListCache.
Comment 1 Cameron McCormack (:heycam) 2022-06-18 16:29:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1618
Comment 2 EWS 2022-06-21 17:40:36 PDT
Committed r295706 (251711@main): <https://commits.webkit.org/251711@main>

Reviewed commits have been landed. Closing PR #1618 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-06-21 17:41:12 PDT
<rdar://problem/95649314>