Bug 241748 - Align uniform*, WebGLMultiDraw, and GraphicsContextGLANGLE functions
Summary: Align uniform*, WebGLMultiDraw, and GraphicsContextGLANGLE functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 219140
  Show dependency tree / graph
 
Reported: 2022-06-18 05:22 PDT by Alexey Knyazev
Modified: 2022-06-21 01:20 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Knyazev 2022-06-18 05:22:17 PDT 
* WebGL2RenderingContext::uniform* function signatures should have const qualifiers like their counterparts.
* WebGL2RenderingContext::uniform* function signatures should use rvalue references for typed arrays.
* WebGLMultiDraw should not redefine TypedList class.
* WebGLMultiDraw::multiDraw* function signatures should use rvalue references for typed arrays.
* WebGLRenderingContextBase::uniform1* should skip extra validation when using ANGLE.
* All draw and clear commands from GraphicsContextGLANGLE should end with checkGPUStatus.
Comment 1 EWS 2022-06-21 01:19:59 PDT 
Committed r295682 (251687@main): <https://commits.webkit.org/251687@main>

Reviewed commits have been landed. Closing PR #1616 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-06-21 01:20:22 PDT 
<rdar://problem/95577796>