Bug 241734 - REGRESSION (r294902): Content with continuation leaves decoration bits behind when removed
Summary: REGRESSION (r294902): Content with continuation leaves decoration bits behind...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-17 17:01 PDT by zalan
Modified: 2022-06-19 20:57 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.40 KB, patch)
2022-06-17 17:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.37 KB, patch)
2022-06-18 13:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.31 KB, patch)
2022-06-19 16:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-06-17 17:01:44 PDT 
<rdar://95308322>
Comment 1 zalan 2022-06-17 17:21:15 PDT 
Created attachment 460322 [details]
Patch
Comment 2 zalan 2022-06-18 13:16:33 PDT 
Created attachment 460333 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-06-19 08:24:50 PDT 
Comment on attachment 460333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460333&action=review

> LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html:29
> +    result.innerText = internals.repaintRectsAsText().indexOf("8 8 140 126") != -1 ? "PASS" : "FAIL";

This seems fragile. Maybe use a more relaxed test?
Comment 4 zalan 2022-06-19 16:15:36 PDT 
Created attachment 460342 [details]
Patch
Comment 5 zalan 2022-06-19 16:52:19 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 460333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460333&action=review
> 
> > LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html:29
> > +    result.innerText = internals.repaintRectsAsText().indexOf("8 8 140 126") != -1 ? "PASS" : "FAIL";
> 
> This seems fragile. 
This is very precise, yes. It's the exact position/size of the box that needs repainting. I am open to suggestions, but block level boxes tend no to fluctuate their position/size.
Comment 6 EWS 2022-06-19 20:57:31 PDT 
Committed r295665 (251670@main): <https://commits.webkit.org/251670@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460342 [details].