Bug 241727 - REGRESSION (251613@main): Missing exception check in JSFunction::put()
Summary: REGRESSION (251613@main): Missing exception check in JSFunction::put()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-17 13:44 PDT by Karl Rackler
Modified: 2022-06-18 03:01 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Rackler 2022-06-17 13:44:40 PDT
Description:
Multiple JSC and jsc-cloop tests are consistent failures. 

The first failure build failures are https://build.webkit.org/#/builders/378/builds/1242, https://build.webkit.org/#/builders/378/builds/1242, and https://build.webkit.org/#/builders/433/builds/3848.

251613@main modified JSFunction.cpp so that possibly introduced the consistent failures.

jscore-test and webkit-jsc-cloop-test stdio:
tress/put-to-proto-chain-overrides-put.js.default: ERROR: Unchecked JS exception:
stress/put-to-proto-chain-overrides-put.js.default:     This scope can throw a JS exception: reifyLazyBoundNameIfNeeded @ runtime/JSFunction.cpp:675
stress/put-to-proto-chain-overrides-put.js.default:         (ExceptionScope::m_recursionDepth was 8)
stress/put-to-proto-chain-overrides-put.js.default:     But the exception was unchecked as of this scope: putInlineSlow @ runtime/JSObject.cpp:766
stress/put-to-proto-chain-overrides-put.js.default:         (ExceptionScope::m_recursionDepth was 8)
Comment 1 Radar WebKit Bug Importer 2022-06-17 13:44:59 PDT
<rdar://problem/95411104>
Comment 2 Alexey Shvayka 2022-06-18 02:54:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1614
Comment 3 EWS 2022-06-18 03:01:21 PDT
Committed r295659 (251664@main): <https://commits.webkit.org/251664@main>

Reviewed commits have been landed. Closing PR #1614 and removing active labels.