Bug 241706 - [ews-build.webkit.org] Support periods in reviewer name
Summary: [ews-build.webkit.org] Support periods in reviewer name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-16 17:02 PDT by Jonathan Bedard
Modified: 2022-06-17 08:22 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-06-16 17:02:07 PDT 
ews-build.webkit.org will not correctly identify a user as a reviewer if that reviewer's name has a period in it. Additionally, we should respect aliases while reviewing.
Comment 1 Jonathan Bedard 2022-06-16 17:06:56 PDT 
Actually, scrapping the alias bit, that's quite dangerous given people's old IRC aliases may match another GitHub user's username
Comment 2 Jonathan Bedard 2022-06-16 17:10:35 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1589
Comment 3 Radar WebKit Bug Importer 2022-06-16 17:25:19 PDT 
<rdar://problem/95343932>
Comment 4 EWS 2022-06-17 08:22:37 PDT 
Committed r295634 (251639@main): <https://commits.webkit.org/251639@main>

Reviewed commits have been landed. Closing PR #1589 and removing active labels.