WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241706
[ews-build.webkit.org] Support periods in reviewer name
https://bugs.webkit.org/show_bug.cgi?id=241706
Summary
[ews-build.webkit.org] Support periods in reviewer name
Jonathan Bedard
Reported
2022-06-16 17:02:07 PDT
ews-build.webkit.org will not correctly identify a user as a reviewer if that reviewer's name has a period in it. Additionally, we should respect aliases while reviewing.
Attachments
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2022-06-16 17:06:56 PDT
Actually, scrapping the alias bit, that's quite dangerous given people's old IRC aliases may match another GitHub user's username
Jonathan Bedard
Comment 2
2022-06-16 17:10:35 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1589
Radar WebKit Bug Importer
Comment 3
2022-06-16 17:25:19 PDT
<
rdar://problem/95343932
>
EWS
Comment 4
2022-06-17 08:22:37 PDT
Committed
r295634
(
251639@main
): <
https://commits.webkit.org/251639@main
> Reviewed commits have been landed. Closing PR #1589 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug