Bug 241681 - Assorted build-time warnings fixes
Summary: Assorted build-time warnings fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-16 05:46 PDT by Claudio Saavedra
Modified: 2022-06-16 22:28 PDT (History)
12 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2022-06-16 05:50 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch (3.83 KB, patch)
2022-06-16 08:08 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2022-06-16 05:46:44 PDT 
Assorted build-time warnings fixes
Comment 1 Claudio Saavedra 2022-06-16 05:50:18 PDT 
Created attachment 460270 [details]
Patch
Comment 2 Mark Lam 2022-06-16 07:50:45 PDT 
Comment on attachment 460270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review

> Source/JavaScriptCore/bytecode/Repatch.cpp:1818
> +                if (callCase.codeBlock()) {

Wrong fix.  The right thing to do is to use codeBlock in the body below.
Comment 3 Claudio Saavedra 2022-06-16 08:03:11 PDT 
Comment on attachment 460270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review

>> Source/JavaScriptCore/bytecode/Repatch.cpp:1818
>> +                if (callCase.codeBlock()) {
> 
> Wrong fix.  The right thing to do is to use codeBlock in the body below.

I simply followed what is done in the same method further down in the code, but OK.
Comment 4 Claudio Saavedra 2022-06-16 08:08:08 PDT 
Created attachment 460271 [details]
Patch
Comment 5 Mark Lam 2022-06-16 09:14:49 PDT 
Comment on attachment 460271 [details]
Patch

r=me
Comment 6 EWS 2022-06-16 22:27:05 PDT 
Committed r295627 (251632@main): <https://commits.webkit.org/251632@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460271 [details].
Comment 7 Radar WebKit Bug Importer 2022-06-16 22:28:18 PDT 
<rdar://problem/95358993>