Bug 241674 - [GPUProcess] [CG] Create ShareableBitmap with sRGB color-space when sending NativeImages to GPUProcess
Summary: [GPUProcess] [CG] Create ShareableBitmap with sRGB color-space when sending N...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-15 21:16 PDT by Said Abou-Hallawa
Modified: 2022-06-21 02:40 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-06-15 21:16:20 PDT 
Sometimes CG fails to create GraphicsContext for some color-spaces. The conversion to sRGB will happen anyway when drawing the image to the destination GraphicsContext. So let's create ShareableBitmap with sRGB color-space when sending NativeImages to GPUProcess.
Comment 1 Said Abou-Hallawa 2022-06-15 21:16:49 PDT 
rdar://95048318
Comment 2 Said Abou-Hallawa 2022-06-15 21:23:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1571
Comment 3 Alexey Proskuryakov 2022-06-16 11:24:19 PDT 
> The conversion to sRGB will happen anyway when drawing the image to the destination GraphicsContext. 

This sounds surprising. How do we support bigger color spaces then?
Comment 4 Said Abou-Hallawa 2022-06-21 02:40:14 PDT 
This seems to be a bug in one of the underlying frameworks.