Bug 241613 – AX: AccessibilityObject::insertText does not insert any text into password fields

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

AccessibilityObject::insertText does not insert any text into password fields

[Radar WebKit Bug Importer]

<rdar://problem/95142865>

[Tyler Wilcock]

rdar://94407238

[Tyler Wilcock]

Created attachment 460237 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Created attachment 460237 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
+++ a/Source/WebCore/accessibility/AccessibilityObject.cpp

+    bool isPasswordField = false;
+    if (auto* inputElement = dynamicDowncast<HTMLInputElement>(element))
+        isPasswordField = inputElement->isPasswordField();

Can we use the override of isPasswordField() instead of recreating that logic here?

[Tyler Wilcock]

Created attachment 460244 [details]
Patch

[Tyler Wilcock]

(In reply to Andres Gonzalez from comment #4)
> (In reply to Tyler Wilcock from comment #3)
> > Created attachment 460237 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/AccessibilityObject.cpp
> +++ a/Source/WebCore/accessibility/AccessibilityObject.cpp
> 
> +    bool isPasswordField = false;
> +    if (auto* inputElement = dynamicDowncast<HTMLInputElement>(element))
> +        isPasswordField = inputElement->isPasswordField();
> 
> Can we use the override of isPasswordField() instead of recreating that
> logic here?
Fixed.

[EWS]

Committed r295553 (251558@main): <https://commits.webkit.org/251558@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460244 [details].