Bug 241613 - AX: AccessibilityObject::insertText does not insert any text into password fields
Summary: AX: AccessibilityObject::insertText does not insert any text into password fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-14 14:09 PDT by Tyler Wilcock
Modified: 2022-06-14 23:38 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.45 KB, patch)
2022-06-14 14:29 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (6.30 KB, patch)
2022-06-14 18:01 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-06-14 14:09:22 PDT
AccessibilityObject::insertText does not insert any text into password fields
Comment 1 Radar WebKit Bug Importer 2022-06-14 14:09:31 PDT
<rdar://problem/95142865>
Comment 2 Tyler Wilcock 2022-06-14 14:19:05 PDT
rdar://94407238
Comment 3 Tyler Wilcock 2022-06-14 14:29:55 PDT
Created attachment 460237 [details]
Patch
Comment 4 Andres Gonzalez 2022-06-14 16:57:07 PDT
(In reply to Tyler Wilcock from comment #3)
> Created attachment 460237 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
+++ a/Source/WebCore/accessibility/AccessibilityObject.cpp

+    bool isPasswordField = false;
+    if (auto* inputElement = dynamicDowncast<HTMLInputElement>(element))
+        isPasswordField = inputElement->isPasswordField();

Can we use the override of isPasswordField() instead of recreating that logic here?
Comment 5 Tyler Wilcock 2022-06-14 18:01:18 PDT
Created attachment 460244 [details]
Patch
Comment 6 Tyler Wilcock 2022-06-14 18:01:43 PDT
(In reply to Andres Gonzalez from comment #4)
> (In reply to Tyler Wilcock from comment #3)
> > Created attachment 460237 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/AccessibilityObject.cpp
> +++ a/Source/WebCore/accessibility/AccessibilityObject.cpp
> 
> +    bool isPasswordField = false;
> +    if (auto* inputElement = dynamicDowncast<HTMLInputElement>(element))
> +        isPasswordField = inputElement->isPasswordField();
> 
> Can we use the override of isPasswordField() instead of recreating that
> logic here?
Fixed.
Comment 7 EWS 2022-06-14 23:38:38 PDT
Committed r295553 (251558@main): <https://commits.webkit.org/251558@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460244 [details].