Bug 241586 - Xcode-based bots rebuilding all of WebKit every build
Summary: Xcode-based bots rebuilding all of WebKit every build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-13 22:37 PDT by Elliott Williams
Modified: 2022-06-14 15:53 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-06-13 22:37:39 PDT
We thought that the switch to workspace builds in https://bugs.webkit.org/show_bug.cgi?id=241298 would fix the issue where every build would be effectively a world build. It has not! Something else must be different between the XCBuild queue I've been using for testing, and the main build queues.

For example: the build for https://commits.webkit.org/251508@main, which is an entirely non-code change, finished in 1:27 on the testing XCBuild queue <https://build.webkit.org/#/builders/463/builds/3154> but took 43:15 on one of the main post-commit queues <https://build.webkit.org/#/builders/29/builds/13435>.

After talking with Jonathan, I'm guessing that Tools/CISupport/built-product-archive is the issue, because it deletes built products out of ./WebKitBuild during normal operation.
Comment 1 Elliott Williams 2022-06-14 12:03:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1516
Comment 2 EWS 2022-06-14 15:52:22 PDT
Committed r295543 (251548@main): <https://commits.webkit.org/251548@main>

Reviewed commits have been landed. Closing PR #1516 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-06-14 15:53:14 PDT
<rdar://problem/95150428>