Bug 241577 - [GPU Process] [Filters] Remove SVGFilterBuilder
Summary: [GPU Process] [Filters] Remove SVGFilterBuilder
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
Keywords: InRadar
Depends on:
Reported: 2022-06-13 16:36 PDT by Said Abou-Hallawa
Modified: 2022-06-13 23:33 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-06-13 16:36:19 PDT
After r295498, all the methods of SVGFilterBuilder became static. So let's remove it and move its methods to SVGFilter.

This change will make SVGFilter and CSSFilter be very similar regarding the layout and the creation. CSSFilter::create() and SVGFilter::create() are responsible of creating the filters. And CSSFilter::calculateOutsets() and SVGFilter::calculateOutsets() can help knowing how much outsets they need to draw correctly.
Comment 1 Said Abou-Hallawa 2022-06-13 16:59:03 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1487
Comment 2 Radar WebKit Bug Importer 2022-06-13 19:03:53 PDT
Comment 3 EWS 2022-06-13 23:33:48 PDT
Committed r295517 (251522@main): <https://commits.webkit.org/251522@main>

Reviewed commits have been landed. Closing PR #1487 and removing active labels.