Bug 241488 - computeUnderlineOffset should not take InlineIterator::LineBoxIterator
Summary: computeUnderlineOffset should not take InlineIterator::LineBoxIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 241442
  Show dependency tree / graph
 
Reported: 2022-06-09 13:55 PDT by zalan
Modified: 2022-06-10 08:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.67 KB, patch)
2022-06-09 14:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-06-09 13:55:20 PDT 
ssia
Comment 1 zalan 2022-06-09 14:00:07 PDT 
Created attachment 460143 [details]
Patch
Comment 2 Antti Koivisto 2022-06-10 05:39:05 PDT 
Comment on attachment 460143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460143&action=review

> COMMIT_MESSAGE:10
> +* Source/WebCore/style/InlineTextBoxStyle.cpp:

This stuff in the wrong directory btw, it should be in rendering (or hypothetical /paint or /display).
Comment 3 zalan 2022-06-10 06:21:55 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 460143 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460143&action=review
> 
> > COMMIT_MESSAGE:10
> > +* Source/WebCore/style/InlineTextBoxStyle.cpp:
> 
> This stuff in the wrong directory btw, it should be in rendering (or
> hypothetical /paint or /display).
totally!
Comment 4 EWS 2022-06-10 08:19:53 PDT 
Committed r295453 (251459@main): <https://commits.webkit.org/251459@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460143 [details].
Comment 5 Radar WebKit Bug Importer 2022-06-10 08:20:25 PDT 
<rdar://problem/94814013>