I'm out of time for today and will get to these first thing tomorrow morning. Sorry about the regressions. // Just needs new expected results. fast/events/standalone-image-drag-to-editable.html // Hits a new assert I added. Will remove the assert and put a FIXME in it's place (the codepath wasn't new, just the assert) fast/forms/search-click-in-placeholder.html // Still need to look into these. fast/inline/dirtyLinesForInline.html svg/custom/pointer-events-image.svg svg/custom/pointer-events-path.svg svg/custom/pointer-events-text.svg
The commits in question: http://trac.webkit.org/changeset/41206 http://trac.webkit.org/changeset/41191 http://trac.webkit.org/changeset/41199
For fast/forms/search-click-in-placeholder.html, the ASSERT it hits is: http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderBlock.cpp#L3464 Which should only be hit when there is a RootLineBox which has no children. (Which makes no sense to me). But it seems that is exactly the case with placeholder text?
Created attachment 27990 [details] Fix test regressions from positionForCoordinates patch. LayoutTests/ChangeLog | 12 ++++++++++++ ...dalone-image-drag-to-editable-expected.checksum | 2 +- .../standalone-image-drag-to-editable-expected.png | Bin 24155 -> 24164 bytes .../standalone-image-drag-to-editable-expected.txt | 11 +++++++---- .../fast/inline/dirtyLinesForInline-expected.txt | 2 +- .../svg/custom/pointer-events-path-expected.txt | 2 +- WebCore/ChangeLog | 9 +++++++++ WebCore/rendering/RenderBlock.cpp | 3 ++- 8 files changed, 33 insertions(+), 8 deletions(-)
Created attachment 27993 [details] Fix test regressions from positionForCoordinates patch. 3 new results and 1 removal of an assert. LayoutTests/ChangeLog | 12 ++++++++++++ ...dalone-image-drag-to-editable-expected.checksum | 2 +- .../standalone-image-drag-to-editable-expected.png | Bin 24155 -> 24164 bytes .../standalone-image-drag-to-editable-expected.txt | 11 +++++++---- .../fast/inline/dirtyLinesForInline-expected.txt | 2 +- .../svg/custom/pointer-events-path-expected.txt | 2 +- WebCore/ChangeLog | 9 +++++++++ WebCore/rendering/RenderBlock.cpp | 3 ++- 8 files changed, 33 insertions(+), 8 deletions(-)
Created attachment 27994 [details] Fix svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg WebCore/ChangeLog | 28 +++++++++++++++++ WebCore/rendering/RenderSVGInlineText.cpp | 18 +++++++---- WebCore/rendering/SVGInlineTextBox.cpp | 47 ++++++++++++++++------------- 3 files changed, 66 insertions(+), 27 deletions(-)
Comment on attachment 27993 [details] Fix test regressions from positionForCoordinates patch. 3 new results and 1 removal of an assert. Needs documentation of the pointer-events-path improvement in the ChangeLOg.
Created attachment 27995 [details] Fix test regressions from positionForCoordinates patch. 3 new results and 1 removal of an assert. LayoutTests/ChangeLog | 23 ++++++++++++++++++++ ...dalone-image-drag-to-editable-expected.checksum | 2 +- .../standalone-image-drag-to-editable-expected.png | Bin 24155 -> 24164 bytes .../standalone-image-drag-to-editable-expected.txt | 11 ++++++--- .../fast/inline/dirtyLinesForInline-expected.txt | 2 +- .../svg/custom/pointer-events-path-expected.txt | 2 +- WebCore/ChangeLog | 9 +++++++ WebCore/rendering/RenderBlock.cpp | 3 +- 8 files changed, 44 insertions(+), 8 deletions(-)
Comment on attachment 27995 [details] Fix test regressions from positionForCoordinates patch. 3 new results and 1 removal of an assert. Looks good.
Comment on attachment 27995 [details] Fix test regressions from positionForCoordinates patch. 3 new results and 1 removal of an assert. Landed Ojan's patch as Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum M LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.png M LayoutTests/platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt M LayoutTests/platform/mac/fast/inline/dirtyLinesForInline-expected.txt M LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.txt M WebCore/ChangeLog M WebCore/rendering/RenderBlock.cpp Committed r41237 Marking as obsolete so that Dave (or someone) can review my remaining patch on this bug. ;)
Comment on attachment 27994 [details] Fix svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg r=me
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/SVGInlineTextBox.cpp Committed r41269 Yay! No more regressions!