Bug 241459 - [shrink-to-fit] Incorrect sizing of elements with visually hidden text inside
Summary: [shrink-to-fit] Incorrect sizing of elements with visually hidden text inside
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 15
Hardware: All All
: P2 Minor
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2022-06-09 04:50 PDT by Wojciech Maj
Modified: 2022-06-12 07:46 PDT (History)
12 users (show)

See Also:

Offline repro (1.54 KB, text/html)
2022-06-09 04:50 PDT, Wojciech Maj
no flags Details
Test reduction (277 bytes, text/html)
2022-06-09 06:17 PDT, zalan
no flags Details
Patch (5.11 KB, patch)
2022-06-11 15:05 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2022-06-11 19:13 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Maj 2022-06-09 04:50:51 PDT
Created attachment 460128 [details]
Offline repro

If we have:
1. div with display: inline-block, or
2. div in flexbox container
that has a text with visually hidden element inside, this div's auto width is incorrect (unnecessarily small), causing the text to wrap with no reason.


Interactive repro:

This can be reproduced both on macOS Monterey and iOS 15.
Comment 1 zalan 2022-06-09 06:17:28 PDT
Created attachment 460130 [details]
Test reduction

Apparently the combination of out-of-flow block box + margin offset confuses the preferred with computation for shrink-to-fit content.
Comment 2 zalan 2022-06-11 08:28:57 PDT
The margin is mistakenly included twice during line layout, first when the out-of-flow box is placed (static position) and later when the adjacent text content is taken care of.
Comment 3 zalan 2022-06-11 15:05:02 PDT
Created attachment 460183 [details]
Comment 4 zalan 2022-06-11 19:13:41 PDT
Created attachment 460184 [details]
Comment 5 EWS 2022-06-12 07:45:30 PDT
Committed r295478 (251483@main): <https://commits.webkit.org/251483@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460184 [details].
Comment 6 Radar WebKit Bug Importer 2022-06-12 07:46:15 PDT