Bug 241444 - AX: Update the isolated tree in response to dynamic changes to aria-live, aria-relevant, and aria-atomic
Summary: AX: Update the isolated tree in response to dynamic changes to aria-live, ari...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-08 18:44 PDT by Tyler Wilcock
Modified: 2022-06-09 23:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (38.42 KB, patch)
2022-06-08 18:47 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (41.47 KB, patch)
2022-06-08 21:59 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (41.44 KB, patch)
2022-06-09 15:11 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-06-08 18:44:40 PDT
Update the isolated tree in response to dynamic changes to aria-live, aria-relevant, and aria-atomic
Comment 1 Radar WebKit Bug Importer 2022-06-08 18:44:49 PDT
<rdar://problem/94682718>
Comment 2 Tyler Wilcock 2022-06-08 18:47:40 PDT
Created attachment 460108 [details]
Patch
Comment 3 chris fleizach 2022-06-08 21:32:24 PDT
Comment on attachment 460108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460108&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1309
> +    const AtomString& liveRegionStatus = getAttribute(aria_liveAttr);

this could be auto

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1318
> +    const AtomString& relevant = getAttribute(aria_relevantAttr);

this could be auto

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1328
> +    const AtomString& atomic = getAttribute(aria_atomicAttr);

this could be auto
Comment 4 Tyler Wilcock 2022-06-08 21:59:39 PDT
Created attachment 460111 [details]
Patch
Comment 5 Tyler Wilcock 2022-06-09 15:11:43 PDT
Created attachment 460147 [details]
Patch
Comment 6 EWS 2022-06-09 23:25:35 PDT
Committed r295446 (251452@main): <https://commits.webkit.org/251452@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460147 [details].