RESOLVED FIXED 241435
RenderImageResource::setCachedImage may produce a null renderer 
https://bugs.webkit.org/show_bug.cgi?id=241435
Summary RenderImageResource::setCachedImage may produce a null renderer
zalan
Reported 2022-06-08 13:33:29 PDT
<rdar://93714107>
Attachments
[fast-cq]Patch (1.26 KB, patch)
2022-06-08 13:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-06-08 13:37:42 PDT
Created attachment 460101 [details] [fast-cq]Patch
Brent Fulgham
Comment 2 2022-06-08 13:42:09 PDT
Comment on attachment 460101 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460101&action=review > Source/WebCore/rendering/RenderImageResource.cpp:67 > + // removeClient may have destroyed the renderer. Don't we still want to set the m_cachedimage value below (even though the existing renderer was possible destroyed)?
Brent Fulgham
Comment 3 2022-06-08 13:51:09 PDT
Comment on attachment 460101 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460101&action=review >> Source/WebCore/rendering/RenderImageResource.cpp:67 >> + // removeClient may have destroyed the renderer. > > Don't we still want to set the m_cachedimage value below (even though the existing renderer was possible destroyed)? I spoke to Alan offline. If 'm_renderer' is nullptr, we expect 'this' to be nullptr as well, so we should early return.
EWS
Comment 4 2022-06-08 14:02:24 PDT
Committed r295393 (251399@main): <https://commits.webkit.org/251399@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460101 [details].
Antoine Quint
Comment 5 2022-06-14 08:15:07 PDT
*** Bug 241512 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 6 2022-06-14 08:49:18 PDT
Bug 241512 has a user-visible symptom, suggesting that we could create a layout test for this patch.
zalan
Comment 7 2022-06-14 09:33:25 PDT
(In reply to Simon Fraser (smfr) from comment #6) > Bug 241512 has a user-visible symptom, suggesting that we could create a > layout test for this patch. That would be awesome given the speculative nature of this fix.
zalan
Comment 8 2022-06-14 09:41:29 PDT
Yeah I can repro it (and it's <rdar://94689000>)
Note You need to log in before you can comment on or make changes to this bug.