Bug 24141 - Add clarity to V8 interceptor helper function.
Summary: Add clarity to V8 interceptor helper function.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-24 15:34 PST by Dimitri Glazkov (Google)
Modified: 2009-02-25 13:18 PST (History)
1 user (show)

See Also:

Attachments
Add clarity to V8 interceptor helper function, v1. (3.33 KB, patch)
2009-02-24 15:38 PST, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-24 15:34:38 PST 
By renaming it to notHandledByInterceptor!
Comment 1 Dimitri Glazkov (Google) 2009-02-24 15:38:50 PST 
Created attachment 27939 [details]
Add clarity to V8 interceptor helper function, v1.

 WebCore/ChangeLog                                  |   13 +++++++++++++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |   16 ++++++++--------
 2 files changed, 21 insertions(+), 8 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-24 16:03:06 PST 
Comment on attachment 27939 [details]
Add clarity to V8 interceptor helper function, v1.

OK.
Comment 3 Dimitri Glazkov (Google) 2009-02-24 16:14:42 PST 
Landed as http://trac.webkit.org/changeset/41196.
Comment 4 Tony Chang 2009-02-25 12:32:11 PST 
Should there be a change to V8Proxy.h to reflect the function rename?
Comment 5 Dimitri Glazkov (Google) 2009-02-25 13:18:18 PST 
I landed it downstream. I intentionally keep V8Proxy.h from landing upstream until all of the custom bindings are done and it actually replaces v8_proxy.h. To keep it loose, y'know?