WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 24141
Add clarity to V8 interceptor helper function.
https://bugs.webkit.org/show_bug.cgi?id=24141
Summary
Add clarity to V8 interceptor helper function.
Dimitri Glazkov (Google)
Reported
2009-02-24 15:34:38 PST
By renaming it to notHandledByInterceptor!
Attachments
Add clarity to V8 interceptor helper function, v1.
(3.33 KB, patch)
2009-02-24 15:38 PST
,
Dimitri Glazkov (Google)
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-02-24 15:38:50 PST
Created
attachment 27939
[details]
Add clarity to V8 interceptor helper function, v1. WebCore/ChangeLog | 13 +++++++++++++ .../v8/custom/V8HTMLPlugInElementCustom.cpp | 16 ++++++++-------- 2 files changed, 21 insertions(+), 8 deletions(-)
Eric Seidel (no email)
Comment 2
2009-02-24 16:03:06 PST
Comment on
attachment 27939
[details]
Add clarity to V8 interceptor helper function, v1. OK.
Dimitri Glazkov (Google)
Comment 3
2009-02-24 16:14:42 PST
Landed as
http://trac.webkit.org/changeset/41196
.
Tony Chang
Comment 4
2009-02-25 12:32:11 PST
Should there be a change to V8Proxy.h to reflect the function rename?
Dimitri Glazkov (Google)
Comment 5
2009-02-25 13:18:18 PST
I landed it downstream. I intentionally keep V8Proxy.h from landing upstream until all of the custom bindings are done and it actually replaces v8_proxy.h. To keep it loose, y'know?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug