Bug 241391 - WebCore::Color::operator= could be cheaper
Summary: WebCore::Color::operator= could be cheaper
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-07 17:08 PDT by Cameron McCormack (:heycam)
Modified: 2022-06-17 22:26 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-06-07 17:08:24 PDT
Currently Color::operator= checks for full equality of the two Color objects before proceeding to do the assignment.  We really only need to check that the deref/ref sequence of an out-of-line component is safe.
Comment 1 Radar WebKit Bug Importer 2022-06-07 17:08:31 PDT
<rdar://problem/94582055>
Comment 2 Cameron McCormack (:heycam) 2022-06-17 22:26:40 PDT
This was a regression on the benchmark I was targeting.