Bug 24137 - Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms
Summary: Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 23359
  Show dependency treegraph
 
Reported: 2009-02-24 14:33 PST by Simon Fraser (smfr)
Modified: 2009-02-24 18:50 PST (History)
3 users (show)

See Also:


Attachments
Patch, changelog (31.64 KB, patch)
2009-02-24 16:52 PST, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-02-24 14:33:44 PST
localToAbsolute() and absoluteToLocal() need to correctly map points through 3d transforms, taking perspective and transform-style into account.
Comment 1 Simon Fraser (smfr) 2009-02-24 16:52:03 PST
Created attachment 27943 [details]
Patch, changelog

I have extensive test cases, but I can't land them until bug 23943 is landed, and/or we fix hit testing for 3d. So they will come later.
Comment 2 Dave Hyatt 2009-02-24 17:25:55 PST
Comment on attachment 27943 [details]
Patch, changelog

Put TransformState in its own file and don't worry about it being a nested RenderObject struct.  Everything else looks fine to me.

r=me
Comment 3 Simon Fraser (smfr) 2009-02-24 18:50:59 PST
http://trac.webkit.org/changeset/41208