Bug 241369 - [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry
Summary: [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-07 07:56 PDT by Geza Lore
Modified: 2022-06-09 04:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2022-06-07 08:59 PDT, Geza Lore 		no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2022-06-09 02:56 PDT, Geza Lore 		no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2022-06-09 02:58 PDT, Geza Lore 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geza Lore 2022-06-07 07:56:34 PDT 
Patch incoming.
Comment 1 Geza Lore 2022-06-07 08:59:51 PDT 
Created attachment 460062 [details]
Patch
Comment 2 Mark Lam 2022-06-07 11:25:57 PDT 
Comment on attachment 460062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460062&action=review

r=me with comment fix up.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:776
> +    # but are not in RegisterSet::vmCalleeSaveRegisters() need to be saved here.
> +    # I.e.: Only those registers that are callee save in the C ABI, but are not
> +    # callee save in teh JIT ABI.

nit: "here. I.e.: Only" -> "here i.e. only".

/teh/the/
Comment 3 Geza Lore 2022-06-09 02:56:37 PDT 
Created attachment 460118 [details]
Patch
Comment 4 Geza Lore 2022-06-09 02:58:11 PDT 
Created attachment 460119 [details]
Patch
Comment 5 EWS 2022-06-09 04:30:53 PDT 
Committed r295416 (251422@main): <https://commits.webkit.org/251422@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460119 [details].
Comment 6 Radar WebKit Bug Importer 2022-06-09 04:31:16 PDT 
<rdar://problem/94713078>