RESOLVED FIXED 241342
REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=241342
Summary REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistently failing
Ryan Haddad
Reported 2022-06-06 11:48:01 PDT
TestWebKitAPI.HSTS.ThirdParty /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:117 Expected equality of these values: [webView _test_waitForAlert] Which is: " " "http://example.com/ hi" /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:118 Expected equality of these values: httpServer.totalRequests() Which is: 1 2u Which is: 2 https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.HSTS.ThirdParty
Attachments
Patch (1.80 KB, patch)
2022-06-09 10:23 PDT, Alex Christensen
no flags
Radar WebKit Bug Importer
Comment 1 2022-06-06 11:48:10 PDT
Ryan Haddad
Comment 2 2022-06-06 12:03:29 PDT
This test makes requests to example.com, maybe it is the same as https://bugs.webkit.org/show_bug.cgi?id=241233?
Karl Rackler
Comment 3 2022-06-08 14:15:05 PDT
I have disabled this test for iOS while this issue is investigated.
Karl Rackler
Comment 4 2022-06-08 14:20:15 PDT
EWS
Comment 5 2022-06-08 16:06:11 PDT
Test gardening commit r295398 (251404@main): <https://commits.webkit.org/251404@main> Reviewed commits have been landed. Closing PR #1392 and removing active labels.
Alex Christensen
Comment 6 2022-06-08 21:24:49 PDT
Aha! determineITPStateInternal is returning true on macOS and false on iOS, which causes ITP to be enabled by default on macOS but not iOS, which causes the HSTS mitigation to happen on macOS but not iOS. The code is fine, the test needs to just enable ITP everywhere.
Alex Christensen
Comment 7 2022-06-09 10:23:36 PDT
EWS
Comment 8 2022-06-09 14:41:53 PDT
Committed r295437 (251443@main): <https://commits.webkit.org/251443@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460136 [details].
Note You need to log in before you can comment on or make changes to this bug.