Bug 241310 - [LFC][FFC] FlexLayout should only take logical values
Summary: [LFC][FFC] FlexLayout should only take logical values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-04 16:26 PDT by zalan
Modified: 2022-06-05 22:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.64 KB, patch)
2022-06-04 16:29 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq]Patch (9.69 KB, patch)
2022-06-05 10:20 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-06-04 16:26:53 PDT
ssia
Comment 1 zalan 2022-06-04 16:29:29 PDT
Created attachment 460031 [details]
Patch
Comment 2 zalan 2022-06-05 10:20:32 PDT
Created attachment 460040 [details]
[fast-cq]Patch
Comment 3 Antti Koivisto 2022-06-05 12:16:15 PDT
Comment on attachment 460040 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460040&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:84
> +    struct LogicalConstraints {
> +        std::optional<LayoutUnit> verticalSpace;
> +        std::optional<LayoutUnit> horizontalSpace;
> +    };

nice
Comment 4 EWS 2022-06-05 20:51:33 PDT
Committed r295276 (251322@main): <https://commits.webkit.org/251322@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460040 [details].
Comment 5 Radar WebKit Bug Importer 2022-06-05 20:52:13 PDT
<rdar://problem/94416379>