WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241297
[PGO] WebKit always uses empty profiling data on release builds
https://bugs.webkit.org/show_bug.cgi?id=241297
Summary
[PGO] WebKit always uses empty profiling data on release builds
Wenson Hsieh
Reported
2022-06-03 18:09:31 PDT
PROFILE_DATA_PATH_INTERNAL_YES = $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.profdata.compressed; We're missing a `WebKitAdditions` in the release build path.
Attachments
Add attachment
proposed patch, testcase, etc.
Elliott Williams
Comment 1
2022-06-03 18:11:48 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1304
Wenson Hsieh
Comment 2
2022-06-03 18:11:52 PDT
(In reply to Wenson Hsieh from
comment #0
)
> PROFILE_DATA_PATH_INTERNAL_YES = > $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit. > profdata.compressed; > > We're missing a `WebKitAdditions` in the release build path.
(More specifically, this should be `…/WebKitAdditions/Profiling/WebKit`)
EWS
Comment 3
2022-06-03 19:18:15 PDT
Committed
r295259
(
251305@main
): <
https://commits.webkit.org/251305@main
> Reviewed commits have been landed. Closing PR #1304 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2022-06-03 19:19:14 PDT
<
rdar://problem/94376562
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug