Bug 241297 - [PGO] WebKit always uses empty profiling data on release builds
Summary: [PGO] WebKit always uses empty profiling data on release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-03 18:09 PDT by Wenson Hsieh
Modified: 2022-06-03 19:19 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-06-03 18:09:31 PDT 
PROFILE_DATA_PATH_INTERNAL_YES = $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.profdata.compressed;

We're missing a `WebKitAdditions` in the release build path.
Comment 1 Elliott Williams 2022-06-03 18:11:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1304
Comment 2 Wenson Hsieh 2022-06-03 18:11:52 PDT 
(In reply to Wenson Hsieh from comment #0)
> PROFILE_DATA_PATH_INTERNAL_YES =
> $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.
> profdata.compressed;
> 
> We're missing a `WebKitAdditions` in the release build path.

(More specifically, this should be `…/WebKitAdditions/Profiling/WebKit`)
Comment 3 EWS 2022-06-03 19:18:15 PDT 
Committed r295259 (251305@main): <https://commits.webkit.org/251305@main>

Reviewed commits have been landed. Closing PR #1304 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-06-03 19:19:14 PDT 
<rdar://problem/94376562>