WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241284
`git webkit setup` hard codes the path to Xcode in .git/hooks/pre-commit
https://bugs.webkit.org/show_bug.cgi?id=241284
Summary
`git webkit setup` hard codes the path to Xcode in .git/hooks/pre-commit
Tim Horton
Reported
2022-06-03 13:55:24 PDT
I use many Xcodes, and frequently delete them; the hardcoded path in .git/hooks/pre-commit then needs to be updated (or `git webkit setup` re-run). Shouldn't this use xcrun, or something?
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2022-06-05 13:46:59 PDT
We cannot just use xcrun, because this code is not Mac only. But it's not very clear to me why we cannot just use "git", and rely on the PATH.
Radar WebKit Bug Importer
Comment 2
2022-06-06 07:27:05 PDT
<
rdar://problem/94435371
>
Jonathan Bedard
Comment 3
2022-06-06 07:29:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1324
EWS
Comment 4
2022-06-06 08:54:06 PDT
Committed
r295288
(
251334@main
): <
https://commits.webkit.org/251334@main
> Reviewed commits have been landed. Closing PR #1324 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug