RESOLVED FIXED Bug 24128
Upstream more V8 custom bindings
https://bugs.webkit.org/show_bug.cgi?id=24128
Summary Upstream more V8 custom bindings
Dimitri Glazkov (Google)
Reported 2009-02-24 11:19:01 PST
Mostly uninteresting constructors and XSLTProcessor bits.
Attachments
Upstream move V8 custom bindings, v1 (19.33 KB, patch)
2009-02-24 11:26 PST, Dimitri Glazkov (Google)
eric: review+
Dimitri Glazkov (Google)
Comment 1 2009-02-24 11:26:53 PST
Created attachment 27924 [details] Upstream move V8 custom bindings, v1 WebCore/ChangeLog | 20 +++ .../bindings/v8/custom/V8DOMParserConstructor.cpp | 45 ++++++ .../v8/custom/V8MessageChannelConstructor.cpp | 77 ++++++++++ .../v8/custom/V8WebKitCSSMatrixConstructor.cpp | 66 +++++++++ .../v8/custom/V8XMLSerializerConstructor.cpp | 45 ++++++ .../v8/custom/V8XPathEvaluatorConstructor.cpp | 45 ++++++ .../bindings/v8/custom/V8XSLTProcessorCustom.cpp | 153 ++++++++++++++++++++ 7 files changed, 451 insertions(+), 0 deletions(-)
Eric Seidel (no email)
Comment 2 2009-02-24 11:56:27 PST
Comment on attachment 27924 [details] Upstream move V8 custom bindings, v1 It looks fine so long as all your return v8:Undefined() calls have been checked to make sure they shouldn't be return doNotIntercept() or whatever the current name is. Also, you're missing a newline at end of file in at least one file.
Dimitri Glazkov (Google)
Comment 3 2009-02-24 15:51:55 PST
Note You need to log in before you can comment on or make changes to this bug.