Bug 241257 - TextureMapper: if an element has both a mask image and reflection, the part of the reflection isn't painted
Summary: TextureMapper: if an element has both a mask image and reflection, the part o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-02 23:28 PDT by Fujii Hironori
Modified: 2022-06-13 20:34 PDT (History)
8 users (show)

See Also:

Attachments
test case (938 bytes, text/html)
2022-06-02 23:28 PDT, Fujii Hironori 		no flags Details
[screenshot] Safari Technology Preview 145 (95.51 KB, image/png)
2022-06-02 23:35 PDT, Fujii Hironori 		no flags Details
[screenshot] WinCairo (24.07 KB, image/png)
2022-06-02 23:44 PDT, Fujii Hironori 		no flags Details
[screenshot] AppleWin (50.02 KB, image/png)
2022-06-02 23:49 PDT, Fujii Hironori 		no flags Details
WIP patch (6.47 KB, patch)
2022-06-06 17:39 PDT, Fujii Hironori 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP patch (9.52 KB, patch)
2022-06-08 23:42 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (14.45 KB, patch)
2022-06-09 15:09 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
mask-and-reflection.html (1.09 KB, text/html)
2022-06-09 15:11 PDT, Fujii Hironori 		no flags Details
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-06-02 23:28:01 PDT 
Created attachment 459998 [details]
test case

TextureMapper: if a element has both mask image and reflection, the mask image should clip the reflection
Comment 1 Fujii Hironori 2022-06-02 23:35:57 PDT 
Created attachment 459999 [details]
[screenshot] Safari Technology Preview 145
Comment 2 Fujii Hironori 2022-06-02 23:44:57 PDT 
Created attachment 460000 [details]
[screenshot] WinCairo
Comment 3 Fujii Hironori 2022-06-02 23:49:32 PDT 
Created attachment 460001 [details]
[screenshot] AppleWin
Comment 4 Fujii Hironori 2022-06-02 23:51:19 PDT 
AppleWin has a bug that it doesn't show the reflection on the first paint.
Resizing window paints the reflection.
Comment 5 Fujii Hironori 2022-06-02 23:51:25 PDT 
Google Chrome doesn't paint the reflection in this case.
Comment 6 Fujii Hironori 2022-06-06 17:39:43 PDT 
Created attachment 460055 [details]
WIP patch
Comment 7 Fujii Hironori 2022-06-08 23:42:33 PDT 
Created attachment 460116 [details]
WIP patch
Comment 8 Fujii Hironori 2022-06-09 15:09:58 PDT 
Created attachment 460146 [details]
Patch
Comment 9 Fujii Hironori 2022-06-09 15:11:48 PDT 
Created attachment 460148 [details]
mask-and-reflection.html
Comment 10 Radar WebKit Bug Importer 2022-06-09 23:28:12 PDT 
<rdar://problem/94788283>
Comment 11 Don Olmstead 2022-06-13 19:56:39 PDT 
Comment on attachment 460146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460146&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:452
> +    static const size_t OverlapRegionConsolidationThreshold = 4;

Where'd this number come from?
Comment 12 Fujii Hironori 2022-06-13 20:09:12 PDT 
Comment on attachment 460146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460146&action=review

Thank you for the review.

>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:452
>> +    static const size_t OverlapRegionConsolidationThreshold = 4;
> 
> Where'd this number come from?

I just copied it from TextureMapperLayer::paintUsingOverlapRegions.
It was added by 133852@main.
Comment 13 EWS 2022-06-13 20:34:18 PDT 
Committed r295514 (251519@main): <https://commits.webkit.org/251519@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460146 [details].