WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241257
TextureMapper: if an element has both a mask image and reflection, the part of the reflection isn't painted
https://bugs.webkit.org/show_bug.cgi?id=241257
Summary
TextureMapper: if an element has both a mask image and reflection, the part o...
Fujii Hironori
Reported
2022-06-02 23:28:01 PDT
Created
attachment 459998
[details]
test case TextureMapper: if a element has both mask image and reflection, the mask image should clip the reflection
Attachments
test case
(938 bytes, text/html)
2022-06-02 23:28 PDT
,
Fujii Hironori
no flags
Details
[screenshot] Safari Technology Preview 145
(95.51 KB, image/png)
2022-06-02 23:35 PDT
,
Fujii Hironori
no flags
Details
[screenshot] WinCairo
(24.07 KB, image/png)
2022-06-02 23:44 PDT
,
Fujii Hironori
no flags
Details
[screenshot] AppleWin
(50.02 KB, image/png)
2022-06-02 23:49 PDT
,
Fujii Hironori
no flags
Details
WIP patch
(6.47 KB, patch)
2022-06-06 17:39 PDT
,
Fujii Hironori
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP patch
(9.52 KB, patch)
2022-06-08 23:42 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
Patch
(14.45 KB, patch)
2022-06-09 15:09 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
mask-and-reflection.html
(1.09 KB, text/html)
2022-06-09 15:11 PDT
,
Fujii Hironori
no flags
Details
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2022-06-02 23:35:57 PDT
Created
attachment 459999
[details]
[screenshot] Safari Technology Preview 145
Fujii Hironori
Comment 2
2022-06-02 23:44:57 PDT
Created
attachment 460000
[details]
[screenshot] WinCairo
Fujii Hironori
Comment 3
2022-06-02 23:49:32 PDT
Created
attachment 460001
[details]
[screenshot] AppleWin
Fujii Hironori
Comment 4
2022-06-02 23:51:19 PDT
AppleWin has a bug that it doesn't show the reflection on the first paint. Resizing window paints the reflection.
Fujii Hironori
Comment 5
2022-06-02 23:51:25 PDT
Google Chrome doesn't paint the reflection in this case.
Fujii Hironori
Comment 6
2022-06-06 17:39:43 PDT
Created
attachment 460055
[details]
WIP patch
Fujii Hironori
Comment 7
2022-06-08 23:42:33 PDT
Created
attachment 460116
[details]
WIP patch
Fujii Hironori
Comment 8
2022-06-09 15:09:58 PDT
Created
attachment 460146
[details]
Patch
Fujii Hironori
Comment 9
2022-06-09 15:11:48 PDT
Created
attachment 460148
[details]
mask-and-reflection.html
Radar WebKit Bug Importer
Comment 10
2022-06-09 23:28:12 PDT
<
rdar://problem/94788283
>
Don Olmstead
Comment 11
2022-06-13 19:56:39 PDT
Comment on
attachment 460146
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=460146&action=review
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:452 > + static const size_t OverlapRegionConsolidationThreshold = 4;
Where'd this number come from?
Fujii Hironori
Comment 12
2022-06-13 20:09:12 PDT
Comment on
attachment 460146
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=460146&action=review
Thank you for the review.
>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:452 >> + static const size_t OverlapRegionConsolidationThreshold = 4; > > Where'd this number come from?
I just copied it from TextureMapperLayer::paintUsingOverlapRegions. It was added by
133852@main
.
EWS
Comment 13
2022-06-13 20:34:18 PDT
Committed
r295514
(
251519@main
): <
https://commits.webkit.org/251519@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 460146
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug