WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
241251
SharedBuffer argument passed in the various Images class method should be const.
https://bugs.webkit.org/show_bug.cgi?id=241251
Summary
SharedBuffer argument passed in the various Images class method should be const.
Jean-Yves Avenard [:jya]
Reported
2022-06-02 19:19:56 PDT
In
bug 241110
we had to use const_cast to take a strong reference on a SharedBuffer. The various SharedBuffer received from networking are const, but Image related classes take a non-const SharedBuffer reference. SharedBuffer is an immutable object, but passing the objects as const reference is the right thing to do.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-06-02 19:20:17 PDT
<
rdar://problem/94324781
>
Jean-Yves Avenard [:jya]
Comment 2
2022-06-07 08:08:34 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1350
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug