RESOLVED FIXED 24123
Move worker related files from dom directory to worker directory under WebCore. 
https://bugs.webkit.org/show_bug.cgi?id=24123
Summary Move worker related files from dom directory to worker directory under WebCore.
Jian Li
Reported 2009-02-24 08:46:38 PST
Need to move all worker related files from dom directory to worker directory under WebCore. This is in preparation to add platform specific files for workers.
Attachments
Proposed Patch (265.90 KB, patch)
2009-02-24 08:54 PST, Jian Li 		no flags
DetailsFormatted DiffDiff
Proposed Patch (258.30 KB, patch)
2009-02-24 10:10 PST, Jian Li 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-02-24 08:54:02 PST
Created attachment 27919 [details] Proposed Patch This patch only moves all worker related files from dom directory to worker directory, plus changes to build files in all affected platforms.
Alexey Proskuryakov
Comment 2 2009-02-24 09:09:32 PST
Comment on attachment 27919 [details] Proposed Patch Should it be "workers", not "worker"? That would match the name of the spec, and the name of tests directory. There is no need to keep automatically generated function names in ChangeLog CrossThreadCopier looks like something more suitable for WebCore/platform (and it should not be wrapped in ENABLE(WORKERS) if we agree about that).
Jian Li
Comment 3 2009-02-24 10:10:51 PST
Created attachment 27920 [details] Proposed Patch Fixed all issues except that I still keep ENABLE(WORKERS) in CrossThreadCopier.*. I will remove it in next patch.
Alexey Proskuryakov
Comment 4 2009-02-24 10:28:03 PST
Comment on attachment 27920 [details] Proposed Patch > + WARNING: NO TEST CASES ADDED OR CHANGED Please remove this line from ChangeLog. > - </Filter> > + </Filer> Please don't do this. r=me otherwise.
David Levin
Comment 5 2009-02-24 10:33:58 PST
Assigned to me for landing.
David Levin
Comment 6 2009-02-24 15:18:05 PST
Committed as r41193.
David Levin
Comment 7 2009-02-24 15:21:17 PST
fyi, we had to do one line addition for workers to DerivedSources.make when landing this (otherwise a clean build would not work).
Note You need to log in before you can comment on or make changes to this bug.