Bug 24123 - Move worker related files from dom directory to worker directory under WebCore.
Summary: Move worker related files from dom directory to worker directory under WebCore.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-24 08:46 PST by Jian Li
Modified: 2009-02-24 15:21 PST (History)
4 users (show)

See Also:

Attachments
Proposed Patch (265.90 KB, patch)
2009-02-24 08:54 PST, Jian Li 		no flags Details | Formatted Diff | Diff
Proposed Patch (258.30 KB, patch)
2009-02-24 10:10 PST, Jian Li 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-02-24 08:46:38 PST 
Need to move all worker related files from dom directory to worker directory under WebCore. This is in preparation to add platform specific files for workers.
Comment 1 Jian Li 2009-02-24 08:54:02 PST 
Created attachment 27919 [details]
Proposed Patch

This patch only moves  all worker related files from dom directory to worker directory, plus changes to build files in all affected platforms.
Comment 2 Alexey Proskuryakov 2009-02-24 09:09:32 PST 
Comment on attachment 27919 [details]
Proposed Patch

Should it be "workers", not "worker"? That would match the name of the spec, and the name of tests directory.

There is no need to keep automatically generated function names in ChangeLog

CrossThreadCopier looks like something more suitable for WebCore/platform (and it should not be wrapped in ENABLE(WORKERS) if we agree about that).
Comment 3 Jian Li 2009-02-24 10:10:51 PST 
Created attachment 27920 [details]
Proposed Patch

Fixed all issues except that I still keep ENABLE(WORKERS) in CrossThreadCopier.*. I will remove it in next patch.
Comment 4 Alexey Proskuryakov 2009-02-24 10:28:03 PST 
Comment on attachment 27920 [details]
Proposed Patch

> +        WARNING: NO TEST CASES ADDED OR CHANGED

Please remove this line from ChangeLog.

> -		</Filter>
> +		</Filer>

Please don't do this.

r=me otherwise.
Comment 5 David Levin 2009-02-24 10:33:58 PST 
Assigned to me for landing.
Comment 6 David Levin 2009-02-24 15:18:05 PST 
Committed as r41193.
Comment 7 David Levin 2009-02-24 15:21:17 PST 
fyi, we had to do one line addition for workers to DerivedSources.make when landing this (otherwise a clean build would not work).