Bug 241159 – REGRESSION (251097@main): ASSERTION FAILED: m_associatedResources.isEmpty() in WebCore::CachedResourceClient::~CachedResourceClient()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Karl Rackler]

Created attachment 459911 [details]
Crash Log

Description:
[ macOS Debug wk1 ] Bot failed with 25 consistent crashes

The first failure that I saw on the dashboard was on 5/28/2022 at 251097@main. The first build failure I see on the bot is https://build.webkit.org/#/builders/3/builds/8155.  

REPRODUCTION STEPS
I can reproduce this on 251097@main, but unable to reproduce it on 251096@main or earlier.

Command: 
run-webkit-tests --debug --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry http/tests/inspector/dom/didFireEvent.html

Result: 
Unexpected flakiness: crashes (1)
  http/tests/inspector/dom/didFireEvent.html [ Pass Crash ]

History:
https://results.webkit.org/?platform=mac&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Finspector%2Fdom%2FdidFireEvent.html&test=http%2Ftests%2Floading%2Fform-submission-no-load-event.html&test=http%2Ftests%2Fmedia%2Fhls%2Fhls-hdr-switch.html&test=http%2Ftests%2Fmedia%2Fhls%2Fhls-non-zero-start-time.html&test=http%2Ftests%2Fmedia%2Fhls%2Ftrack-in-band-hls-metadata-cue-duration.html&test=http%2Ftests%2Fmedia%2Fmodern-media-controls%2Fskip-back-support%2Fskip-back-support-button-click.html&test=http%2Ftests%2Fmedia%2Ftrack-in-band-hls-metadata-crash.html&test=http%2Ftests%2Fmedia%2Ftrack-in-band-hls-metadata.html&test=http%2Ftests%2Fmedia%2Fvideo-buffered-range-contains-currentTime.html&test=http%2Ftests%2Fmedia%2Fvideo-error-does-not-exist.html&test=http%2Ftests%2Fmedia%2Fvideo-play-stall.html&test=http%2Ftests%2Fmedia%2Fvideo-redirect.html&test=http%2Ftests%2Fmedia%2Fvideo-throttled-load-metadata.html&test=http%2Ftests%2Fpreload%2Fonerror_event.html&test=http%2Ftests%2Fpreload%2Fonload_event.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Faudio-redirect-allowed.html&test=http%2Ftests%2Fsecurity%2Fvideo-poster-cross-origin-crash2.html&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Frange%2Fgeneral.window.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Finfrastructure%2Furls%2Fdynamic-changes-to-base-urls%2Fdynamic-urls.sub.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Finfrastructure%2Furls%2Fdynamic-changes-to-base-urls%2Fhistorical.sub.xhtml&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fembedded-content%2Fmedia-elements%2Fpreserves-pitch.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fembedded-content%2Fthe-audio-element%2Faudio_constructor.html&test=storage%2Fdomstorage%2Fsessionstorage%2Fwindow-open-remove-item.html&test=storage%2Findexeddb%2Fmodern%2Fopendatabase-success-after-versionchange-private.html&test=workers%2Fworker-web-lock-released-on-reload.html&limit=50000

Crash Log:
Thread 0 Crashed:
0 com.apple.JavaScriptCore 0x0000000101ff204e WTFCrash + 14 (Assertions.cpp:322)
1 com.apple.WebCore 0x000000012cdcfb4b WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:748)
2 com.apple.WebCore 0x000000012f0d742c WebCore::CachedResourceClient::~CachedResourceClient() + 156 (CachedResourceClient.h:50)
3 com.apple.WebCore 0x000000012f0c7768 WebCore::CachedRawResourceClient::~CachedRawResourceClient() + 24 (CachedRawResourceClient.h:36)
4 com.apple.WebCore 0x0000000131435403 WebCore::MediaResource::~MediaResource() + 227 (MediaResourceLoader.cpp:166)
5 com.apple.WebCore 0x0000000131435505 WebCore::MediaResource::~MediaResource() + 21 (MediaResourceLoader.cpp:162)

[Radar WebKit Bug Importer]

<rdar://problem/94181625>

[Ryan Haddad]

This was resolved via a revert in https://commits.webkit.org/251166@main