Bug 24115 - Introduce platform independent stubs for plugins
Summary: Introduce platform independent stubs for plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-23 19:11 PST by Laszlo Gombos
Modified: 2009-03-18 09:35 PDT (History)
3 users (show)

See Also:


Attachments
Move wx plug-in stubs to common port independent stubs (19.40 KB, patch)
2009-02-23 19:19 PST, Laszlo Gombos
kevino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-02-23 19:11:53 PST
I noticed that there are 2 implementations for plug-in stubs. One implementation is under WebCore/plugins/wx for the wx port and the other one is in the WebCore/platform/qt/TemporaryLinkStubs.cpp for certain the Qt ports. There is no reason why the stubs could not be shared between the wx and Qt ports and potentially used by other ports as well. 

The proposal is to promote the wx stubs to top level stubs to the WebCore/plugins directory - similarly as this has been handled for IconDatabase(None) and Threading(None).

Patch will follow.
Comment 1 Laszlo Gombos 2009-02-23 19:19:11 PST
Created attachment 27901 [details]
Move wx plug-in stubs to common port independent stubs
Comment 2 Laszlo Gombos 2009-02-23 20:28:25 PST
(In reply to comment #1)
> Created an attachment (id=27901) [review]
> Move wx plug-in stubs to common port independent stubs

I forget to mention that this just promotes the wx stubs to be port independent stubs. I intent to create another bug/patch to take advantage of this in the Qt build.
Comment 3 Kevin Ollivier 2009-03-18 09:35:32 PDT
Landed in r41786, thanks!