We should expose ENABLE_VIDEO as a public build option because it allows disabling GStreamer, a major dependency. This is useful on embedded systems where video is not needed.
Pull request: https://github.com/WebKit/WebKit/pull/1181
Committed r295057 (251152@main): <https://commits.webkit.org/251152@main> Reviewed commits have been landed. Closing PR #1181 and removing active labels.
(In reply to Michael Catanzaro from comment #0) > We should expose ENABLE_VIDEO as a public build option because it allows > disabling GStreamer, a major dependency. This is useful on embedded systems > where video is not needed. For future reference, in case someone arrives to this bug trying to avoid the GStreamer dependency in their builds: ENABLE_VIDEO and ENABLE_WEB_AUDIO need to be *both disabled* in order for the WebKit WPE and GTK ports to avoid the GStreamer dependency.
Oh... and that option is not public either. I suppose I'd better expose that too?
Maybe I should change this to USE_GSTREAMER instead? That can toggle both ENABLE_VIDEO and ENABLE_WEB_AUDIO.
ENABLE_VIDEO and ENABLE_WEB_AUDIO were both already public, in GStreamerDefinitions.cmake: WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC ON) Adrian and I were both wrong. I'll just revert this.
Re-opening for pull request https://github.com/WebKit/WebKit/pull/1249
Committed r295136 (251227@main): <https://commits.webkit.org/251227@main> Reviewed commits have been landed. Closing PR #1249 and removing active labels.