WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241117
Control whether PDF.js is included via a build-time setting
https://bugs.webkit.org/show_bug.cgi?id=241117
Summary
Control whether PDF.js is included via a build-time setting
Elliott Williams
Reported
2022-05-30 19:48:13 PDT
r289850
introduced PDF.js into WebCore, butit was reverted in
r291241
due to its impact on bundle size. Let's find a way to reland the changes as an opt-in feature.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-05-30 19:48:56 PDT
<
rdar://problem/94127873
>
Tim Nguyen (:ntim)
Comment 2
2022-05-31 04:03:59 PDT
It would be nice to reuse ENABLE(PDFJS) or ENABLE_PDFJS (and disable that option by default while we're there).
Elliott Williams
Comment 3
2022-07-01 12:21:50 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2006
Tim Nguyen (:ntim)
Comment 4
2022-07-01 15:07:27 PDT
***
Bug 235981
has been marked as a duplicate of this bug. ***
EWS
Comment 5
2022-07-11 10:11:58 PDT
Committed
252343@main
(d4387ce981a9): <
https://commits.webkit.org/252343@main
> Reviewed commits have been landed. Closing PR #2006 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug