Bug 241117 - Control whether PDF.js is included via a build-time setting
Summary: Control whether PDF.js is included via a build-time setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
: 235981 (view as bug list)
Depends on:
Blocks: 235981
  Show dependency tree / graph
 
Reported: 2022-05-30 19:48 PDT by Elliott Williams
Modified: 2022-07-11 10:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-05-30 19:48:13 PDT 
r289850 introduced PDF.js into WebCore, butit  was reverted in r291241 due to its impact on bundle size. Let's find a way to reland the changes as an opt-in feature.
Comment 1 Radar WebKit Bug Importer 2022-05-30 19:48:56 PDT 
<rdar://problem/94127873>
Comment 2 Tim Nguyen (:ntim) 2022-05-31 04:03:59 PDT 
It would be nice to reuse ENABLE(PDFJS) or ENABLE_PDFJS (and disable that option by default while we're there).
Comment 3 Elliott Williams 2022-07-01 12:21:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2006
Comment 4 Tim Nguyen (:ntim) 2022-07-01 15:07:27 PDT 
*** Bug 235981 has been marked as a duplicate of this bug. ***
Comment 5 EWS 2022-07-11 10:11:58 PDT 
Committed 252343@main (d4387ce981a9): <https://commits.webkit.org/252343@main>

Reviewed commits have been landed. Closing PR #2006 and removing active labels.