Bug 241115 - Commit message not showing up in patch review for some patches
Summary: Commit message not showing up in patch review for some patches
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-30 18:52 PDT by Alexey Proskuryakov
Modified: 2022-06-06 19:14 PDT (History)
3 users (show)

See Also:

Attachments
WIP patch (1.36 KB, patch)
2022-05-30 21:26 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2022-05-30 18:52:06 PDT 
Commit message is not visible in https://bugs.webkit.org/attachment.cgi?id=459876&action=review, although it's present and looks normal in the raw patch, https://bug-241114-attachments.webkit.org/attachment.cgi?id=459876
Comment 1 Fujii Hironori 2022-05-30 21:26:21 PDT 
Created attachment 459877 [details]
WIP patch
Comment 2 Fujii Hironori 2022-05-30 21:28:50 PDT 
I'm not able to find out a good way to decode MIME header with Ruby standard library. 

Subject: =?UTF-8?q?webkit-patch:=20`git=20am`=20strips=20prefixes=20(e.g.?=
 =?UTF-8?q?=20[CMake][WPE])=20in=20a=20subject=0Ahttps://bugs.webkit.org/s?=
 =?UTF-8?q?how=5Fbug.cgi=3Fid=3D241114?=
Comment 3 Fujii Hironori 2022-05-30 21:35:42 PDT 
`git mailinfo` command can decode the subject. But I don't know git command is available on the Bugzilla server.
Comment 4 Alexey Proskuryakov 2022-05-30 23:11:34 PDT 
Running external commands with untrusted content on the server would be icky. I don't know how all this works though, maybe we already do?
Comment 5 Radar WebKit Bug Importer 2022-06-06 18:53:12 PDT 
<rdar://problem/94480379>
Comment 6 Fujii Hironori 2022-06-06 19:14:42 PDT 
Bug 241114 was fixed by using --keep-non-patch option rather than --keep option.
We don't need to fix this problem. Closed.