Bug 241081 – [webkitpy] run-benchmark script fails to find the lsof command on Linux

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The lsof command is shipped on Linux typically on /usr/bin meanwhile on Mac is shipped on /usr/sbin

The GTK perf bot is having issues with this and is causing the tests to fail.

[Carlos Alberto Lopez Perez]

Created attachment 459842 [details]
Patch

[Lauro Moura]

Comment on attachment 459842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459842&action=review

Looks good. Minor suggestion inline.

> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:71
> +                lsof_path = shutil.which('lsof') if shutil.which('lsof') else '/usr/sbin/lsof'

Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the extra which call?

[Lauro Moura]

(In reply to Lauro Moura from comment #2)
> Comment on attachment 459842 [details]
>
> Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the
> extra which call?

Obviously, I meant `lsof_path = ...`.

Comment on attachment 459842 [details]
Patch

r=me

[Radar WebKit Bug Importer]

<rdar://problem/94408913>

[Carlos Alberto Lopez Perez]

(In reply to Lauro Moura from comment #2)
> Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the
> extra which call?

Good idea, seems cleaner.

I will land with this

[Carlos Alberto Lopez Perez]

Created attachment 460226 [details]
Patch for landing

[EWS]

Committed r295520 (251525@main): <https://commits.webkit.org/251525@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460226 [details].