Bug 24108 – Adopt new text checking API for spelling and grammar checking in SnowLeopard

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Justin Garcia]

In place of current, separate calls for spelling and grammar checking, it is now possible to make a single call that will do both, more efficiently and more correctly.  This will be necessary for us to maintain consistent spelling and grammar checking between Mail and TextEdit in Snow Leopard.

<rdar://problem/6088051>

[Justin Garcia]

Created attachment 28153 [details]
doug's patch

[Justin Garcia]

in Frame::respondToChangedSelection why did you remove the call to:

editor()->markMisspellings(oldAdjacentWords);

[Douglas Davidson]

The idea here is to replace the two calls to markMisspellings and markBadGrammar with a single call to markMisspellingsAndBadGrammar, with a bool markGrammar argument to indicate whether it should mark spelling only or spelling and grammar.  The reason for this is that the new text checking will check both at once, and should check both at once wherever possible to save a round trip to the checker.  

There are two cases in Frame::respondToChangedSelection.  If grammar checking is disabled (the else clause) then the markGrammar argument is always false.   If grammar checking is enabled, then we always want to check spelling, but we also want to check grammar if and only if the new selection is in a different sentence from the old one.  Before this change, that was done by calling markBadGrammar only if oldSelectedSentence != newSelectedSentence.  After the change, that is done by making the markGrammar argument true only if oldSelectedSentence != newSelectedSentence.

[Justin Garcia]

Oops I didn't see the else clause my mistake.

[Justin Garcia]

Comment on attachment 28153 [details]
doug's patch

looks good

[Justin Garcia]

r41496