Bug 241057 - [LFC][FFC] Transition flex-grow computation to flex-basis based
Summary: [LFC][FFC] Transition flex-grow computation to flex-basis based
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-27 21:52 PDT by zalan
Modified: 2022-05-28 11:19 PDT (History)
5 users (show)

See Also:

Attachments
[fast-cq]Patch (6.95 KB, patch)
2022-05-27 21:56 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-05-27 21:52:08 PDT 
ssia
Comment 1 zalan 2022-05-27 21:56:13 PDT 
Created attachment 459825 [details]
[fast-cq]Patch
Comment 2 Antti Koivisto 2022-05-27 22:07:02 PDT 
Comment on attachment 459825 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459825&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:299
> +    struct StrechingFlexItem {

very similar to ShrinkingFlexItem
Comment 3 zalan 2022-05-28 07:54:02 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 459825 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459825&action=review
> 
> > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:299
> > +    struct StrechingFlexItem {
> 
> very similar to ShrinkingFlexItem
Yeah, they may converge soon.
Comment 4 EWS 2022-05-28 09:19:03 PDT 
Committed r295000 (251098@main): <https://commits.webkit.org/251098@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459825 [details].
Comment 5 Radar WebKit Bug Importer 2022-05-28 09:20:14 PDT 
<rdar://problem/94075540>