WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241023
REGRESSION(
r294634
): Fix unified build with ContentTypeUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=241023
Summary
REGRESSION(r294634): Fix unified build with ContentTypeUtilities.cpp
Olivier Blin
Reported
2022-05-27 08:47:57 PDT
ContentTypeUtilities.cpp has been added in
r294634
, but it can break some unified builds because of such errors: In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-22.cpp:2: In file included from ../../Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp:27: In file included from ../../Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h:28: In file included from ../../Source/WebCore/platform/graphics/FloatSize.h:30: In file included from ../../Source/WebCore/platform/graphics/IntPoint.h:28: ../../Source/WebCore/platform/graphics/IntSize.h:212:16: error: no type named 'TextStream' in namespace 'WebCore::WTF'; did you mean simply 'TextStream'? WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, const IntSize&); ^~~~~~~~~~~~~~~ TextStream WTF/Headers/wtf/Forward.h:160:12: note: 'TextStream' declared here using WTF::TextStream; ^ This is because it can make <wtf/Forward.h> included from the WebCore namespace.
Attachments
Add attachment
proposed patch, testcase, etc.
Olivier Blin
Comment 1
2022-05-27 08:50:17 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1099
Radar WebKit Bug Importer
Comment 2
2022-06-03 08:48:12 PDT
<
rdar://problem/94347846
>
Olivier Blin
Comment 3
2022-06-27 02:48:26 PDT
Fixed by Cameron McCormack in
https://commits.webkit.org/251669@main
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug