WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
240963
Define WK_NOT_NO in SDKVariant.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=240963
Summary
Define WK_NOT_NO in SDKVariant.xcconfig
David Quesada
Reported
2022-05-26 11:33:26 PDT
The WK_NOT_ build settings can invert "" to "YES" and "YES" to "NO", but can't invert "NO" to "YES". This is problematic for other build configuration that builds upon this construction and only ever expects a value of YES or NO. `WK_NOT_NO` should be defined, with a value of "YES".
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-05-26 11:34:10 PDT
<
rdar://problem/93984643
>
David Quesada
Comment 2
2022-05-26 11:48:38 PDT
https://github.com/WebKit/WebKit/pull/1058
EWS
Comment 3
2022-05-26 14:13:13 PDT
Committed
r294897
(
251020@main
): <
https://commits.webkit.org/251020@main
> Reviewed commits have been landed. Closing PR #1058 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug